This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Rename ambient cache prewarming method #13318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the method for prewarming the ambient cache to conform to Cocoa and Swift naming conventions.
1ec5
force-pushed
the
1ec5-offline-put-rename
branch
from
8b9d3f6 to
6d9f13e
Compare
ChrisLoer
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
This looks like a great improvement to me, as you can see the names I exposed weren't pre-meditated, they were just reflecting the underlying mbgl-core methods.
cc @LukasPaczos -- although naming guidelines are a little different on Android, something like this change would probably be an improvement there (and keep the two platform SDKs closer together).
Yep, no worries. One thing to note that the new method name follows the “set [value] for [key]” pattern that’s peculiar to Objective-C and Swift. In most other languages, the idiom is “set [key] to [value]” instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
-[MGLOfflineStorage putResourceWithUrl:data:modified:expires:etag:mustRevalidate:]to-[MGLOfflineStorage preloadData:forURL:modificationDate:expirationDate:eTag:mustRevalidate:]to conform to Cocoa naming guidelines in Objective-C and Swift API design guidelines in Swift./ref #13119
/cc @fabian-guerra @ChrisLoer